Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] inappchat in greenroom #86

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

sidmohanty11
Copy link
Contributor

  • Added InAppChat to Greenroom with the same layout as before but as soon as @demonicirfan completes the UI part of mainstage, it can be replicated here also

Preview

greenroom1
greenroom2

@Sing-Li
Copy link
Member

Sing-Li commented Mar 4, 2022

Awesome work. Thanks @sidmohanty11 If you have relatively good lighting, DO feel free to add your own mugshot into the screen captures. (there really isn't too many opportunities in open source where you can do this organically) It may feel awkward or embarrasing at the first go. But over time, I assure you that you'll be glad that you did - marking your own growth through time with growing open source contributions. FWIW

@sidmohanty11
Copy link
Contributor Author

Thank you so much for the opportunity!! I will definitely update the screen captures and add a cool picture of myself. :)

@Sing-Li Sing-Li merged commit a6e9464 into RocketChat:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants