Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keycloak - initial #87

Merged
merged 5 commits into from
Mar 13, 2022
Merged

Conversation

abhinavkrin
Copy link
Member

This PR will add keycloak to RC4Community.

@Sing-Li
Copy link
Member

Sing-Li commented Mar 4, 2022

This is awesome. @debdutdeb can you please update our keycloak server and let's get community.rocket.chat working with REAL AUTH. (just can't wait to see the linkage with superprofile - hint Ronlek ;-) )

@debdutdeb debdutdeb mentioned this pull request Mar 4, 2022
@Sing-Li
Copy link
Member

Sing-Li commented Mar 12, 2022

@abhinavkrin please advise if this is good enough to merge for our upcoming Alumni Summit purpose

@Sing-Li
Copy link
Member

Sing-Li commented Mar 12, 2022

Please also make keycloak the default IDM provider (if possible) for RC4Community instead of Firebase.

I've checked out the ISC license. Totally OK to include. Thanks.

@abhinavkrin
Copy link
Member Author

Please also make keycloak the default IDM provider (if possible) for RC4Community instead of Firebase.

I've checked out the ISC license. Totally OK to include. Thanks.

It's fine to merge this PR. The default IDM would be keycloak.
Currently.
The user will have the following attribute:

  1. id
  2. our custom access token
  3. image
  4. name
  5. email

@abhinavkrin abhinavkrin marked this pull request as ready for review March 12, 2022 12:30
@Sing-Li
Copy link
Member

Sing-Li commented Mar 12, 2022

Please remove package-lock.json from the PR (and perhaps add it to your .gitignore) - thanks. @abhinavkrin

@abhinavkrin
Copy link
Member Author

Please remove package-lock.json from the PR (and perhaps add it to your .gitignore) - thanks. @abhinavkrin

Removed package-lock.json @Sing-Li

@Sing-Li Sing-Li merged commit 50f7da2 into RocketChat:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants