Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

Upcoming changes in how avatars are handled #306

Closed
matheusjardimb opened this issue Jun 4, 2017 · 3 comments
Closed

Upcoming changes in how avatars are handled #306

matheusjardimb opened this issue Jun 4, 2017 · 3 comments
Assignees
@matheusjardimb
Labels
👍 improvement

Comments

@matheusjardimb
Copy link
Contributor

App must handle the upcoming changes in the server side (v0.57.0), regarding how avatars are handled.

More details at RocketChat/Rocket.Chat#6788

The easiest approach should be as easy as following a redirect when getting the images.
@matheusjardimb matheusjardimb self-assigned this Jun 4, 2017
@matheusjardimb
Copy link
Contributor Author

@rafaelks any comments on how iOS is dealing with this changes?

@geekgonecrazy
Copy link
Member

@matheusjardimb this RocketChat/Rocket.Chat#7177 seems to fix it actually. 😁

@matheusjardimb
Copy link
Contributor Author

@geekgonecrazy that's awesome! So it seems this issue isn't necessary anymore.
I'm closing it and let's just reopen if any scenario isn't covered 👍

Shailesh351 referenced this issue in Shailesh351/Rocket.Chat.Android Apr 25, 2019
@jaytat0
Merge pull request RocketChat#310 from GOVINDDIXIT/fix#306
ab4b632 
fix: symbols for public/private channels in chat details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matheusjardimb matheusjardimb

Labels
👍 improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geekgonecrazy @matheusjardimb