feature: grab implemented interfaces #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thassiov
commented
Aug 18, 2020
d-gubert
reviewed
Aug 18, 2020
d-gubert
reviewed
Aug 18, 2020
…modules-issue Fix failed to resolve node internal modules issue
d-gubert
reviewed
Sep 1, 2020
d-gubert
reviewed
Sep 1, 2020
d-gubert
reviewed
Sep 1, 2020
Implement Apps compiler contract
The reason is the definition of the type Buffer is in node_modules/node/ts3.2/global.d.ts We can simply uncomment `types: ['node']` to fix the issue :)
Fix `Cannot find name Buffer` error
d-gubert
reviewed
Sep 3, 2020
d-gubert
requested changes
Sep 3, 2020
* Add build command * Make compilation happen on app directory * Fix AppsCompiler test
* import types from typescript directly * intelligent inheritance detection * Add tests holder * Move logic into checkInheritance * Format code * Format code * Refactor Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>
shiqimei
reviewed
Sep 9, 2020
* Add the zip functionality * Clean up old source files * Fix tslint errors * Adjust test case * Remove duplicate `directory` property from the AppsCompiler class * Fix package.json and test case after a faulty conflict resolution * Fix naming of the app package * Some fixes Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
* Rename compiled files to .js * Make package overwrite app manifest with updated data * Add package to the compilation script
This was referenced Sep 14, 2020
Shailesh351
pushed a commit
to Shailesh351/Rocket.Chat.Apps-compiler
that referenced
this pull request
Apr 28, 2021
Create auto_catchup.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.