Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msg_processing_type field to message action #117

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

d-gubert
Copy link
Member

Adds the field introduced in this PR to the engine.

No further changes are needed on Rocket.Chat for it to work.

@d-gubert d-gubert requested a review from rodrigok March 28, 2019 20:23
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #117 into master will increase coverage by 1.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   60.84%   62.62%   +1.77%     
==========================================
  Files          58       65       +7     
  Lines        2084     2183      +99     
  Branches      322      322              
==========================================
+ Hits         1268     1367      +99     
  Misses        816      816
Impacted Files Coverage Δ
src/server/errors/index.ts 100% <0%> (ø)
src/server/managers/index.ts 100% <0%> (ø)
src/server/accessors/index.ts 100% <0%> (ø)
src/server/compiler/index.ts 100% <0%> (ø)
src/server/storage/index.ts 100% <0%> (ø)
src/server/logging/index.ts 100% <0%> (ø)
src/server/bridges/index.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b148600...77fc70c. Read the comment docs.

@d-gubert d-gubert merged commit 1883caf into master Mar 30, 2019
@d-gubert d-gubert deleted the add-message-processing-type-field branch March 30, 2019 20:16
@@ -0,0 +1,4 @@
export enum MessageProcessingType {
SendMessage = 'sendMessage',
RespondWithMessage = 'respondWithMessage',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish there was documentation added that said what each of these do. They both seem the same to me :(

Does sendMessage actually send a message without populating the text area for the user to edit beforehand? Or is that respondWithMessage or what?

@d-gubert d-gubert restored the add-message-processing-type-field branch July 30, 2019 03:31
@d-gubert d-gubert deleted the add-message-processing-type-field branch July 30, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants