Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Livechat features #124

Merged
merged 11 commits into from
Aug 30, 2019
Merged

[NEW] Livechat features #124

merged 11 commits into from
Aug 30, 2019

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented May 24, 2019

Introduces components that enable apps to interact with the Livechat feature on Rocket.Chat.

Closes #122

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #124 into beta will decrease coverage by 0.83%.
The diff coverage is 22.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #124      +/-   ##
==========================================
- Coverage   58.11%   57.28%   -0.84%     
==========================================
  Files          63       76      +13     
  Lines        2230     2505     +275     
  Branches      344      357      +13     
==========================================
+ Hits         1296     1435     +139     
- Misses        934     1070     +136
Impacted Files Coverage Δ
src/server/bridges/AppBridges.ts 100% <ø> (ø) ⬆️
src/server/compiler/AppCompiler.ts 26.03% <ø> (ø) ⬆️
src/server/bridges/index.ts 100% <ø> (ø)
src/server/accessors/Reader.ts 100% <100%> (ø) ⬆️
src/server/managers/AppAccessorManager.ts 100% <100%> (ø) ⬆️
src/server/accessors/index.ts 100% <100%> (ø)
src/server/accessors/UploadRead.ts 22.22% <22.22%> (ø)
src/server/accessors/ModifyCreator.ts 72.13% <22.72%> (-27.87%) ⬇️
src/server/accessors/LivechatCreator.ts 25% <25%> (ø)
src/server/accessors/LivechatRead.ts 33.33% <33.33%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eacfddb...e7da746. Read the comment docs.

@d-gubert d-gubert changed the base branch from master to beta August 28, 2019 17:38
@d-gubert d-gubert marked this pull request as ready for review August 30, 2019 19:35
@d-gubert d-gubert merged commit 5c54beb into beta Aug 30, 2019
@rodrigok rodrigok deleted the livechat-features branch September 18, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants