Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Open uikit contextual bar #451

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

thassiov
Copy link
Contributor

@thassiov thassiov commented Nov 3, 2021

What? β›΅

Why? πŸ€”

Links 🌎

PS πŸ‘€

@thassiov thassiov marked this pull request as ready for review November 3, 2021 12:57
@cuonghuunguyen
Copy link
Contributor

cuonghuunguyen commented Nov 12, 2021

as we had a permission system with Apps Engine, should we allow apps to display Contextual Bar and Modal without the initial interaction from users?
I am making an app for livechat agents to send transfer requests to the other agents. Without modals I am having to use a very complicated custom script

@d-gubert
Copy link
Member

as we had a permission system with Apps Engine, should we allow apps to display Contextual Bar and Modal without the initial interaction from users?

We were not considering making that change, as it is somewhat risky... as in, without this restriction, what will stop apps from spamming modals to users? πŸ€”

@graywolf336
Copy link
Contributor

graywolf336 commented Nov 17, 2021

We were not considering making that change, as it is somewhat risky... as in, without this restriction, what will stop apps from spamming modals to users? πŸ€”

The developers themselves and the marketplace publisher review team. What's to stop an app from spamming messages to users? If we use this same logic in other areas then we will continously hinder apps and what they can do. In my opinion

@d-gubert
Copy link
Member

d-gubert commented Nov 29, 2021

The developers themselves and the marketplace publisher review team.

Having to check for this kind of "bad" behavior in the review process is not scalable.

We've decided to follow this practice as it is something Slack also does, and it looked very reasonable. But we can discuss this again, of course.

What's to stop an app from spamming messages to users?

This argument could go the other way as well. Like, shouldn't we implement some kind of "rate limiter" to say the least so apps would not abuse this power? Might fall in the same discussion mentioned above 🀷

@graywolf336
Copy link
Contributor

In all honesty, I think us erroring on the "safe side" is curtailing creativity more than it's preventing people from spamming. Just my two cents :)

@cuonghuunguyen
Copy link
Contributor

Agree with @graywolf336, we can't prevent all the cases of spamming. But imagine, if we're more open to the Apps Engine, we can bring thousands ideas into life πŸ˜„

@d-gubert d-gubert changed the title [FEAT] Open uikit contextual bar [NEW] Open uikit contextual bar Dec 10, 2021
@d-gubert d-gubert merged commit ab1c8f4 into feat/uikitsurfaces Dec 20, 2021
@d-gubert d-gubert deleted the feat/open-uikit-contextual-bar branch December 20, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants