[NEW] Add Multi-Select setting interfaces on Apps #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Team @RocketChat/apps, Could you please review this PR? Thanks in advance 🙏 |
|
Is there a corresponding Rocket.Chat PR for this or is this already supported by Rocket.Chat? If so, what does it look like on the Apps configuration/settings screen? |
|
No PR for Core is needed, its just a matter of defining these typescript interfaces to support this. Here's how it looks in action |
|
Are the values provided like a regular select? |
Yes, that's correct. It uses the same interfaces Feel free to check out this feature in action here |
graywolf336
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
Added new interfaces for multi-select settings within app
Why? 🤔
Links 🌎
PS 👀