fix: Add default behavior to executeViewCloseHandler for all apps that don't implement it
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanPazRibeiro
previously approved these changes
Apr 30, 2024
d-gubert
reviewed
Apr 30, 2024
AllanPazRibeiro
approved these changes
May 2, 2024
MarcosSpessatto
approved these changes
May 2, 2024
d-gubert
added a commit
that referenced
this pull request
May 2, 2024
…hat don't implement it (#763) Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
Why? 🤔
There was an issue with some apps that didn't implement executeViewCloseHandler. This causes opened modals to be open forever on UI. This is because when the UI attempts to close it, it calls the aforementioned handler, and since it didn't exist, apps engine errored out.
This returned an empty response to the UI, which ignored the response and continued to show the view.
Links 🌎
rocketchat.atlassian.net/browse/CORE-401
PS 👀