-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add support to login through CAS. #91
Conversation
data class CasLoginPayload(val cas: Data) | ||
|
||
@JsonSerializable | ||
data class Data(val credentialToken: String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the name of this class too generic to something like this? Wouldn't be better to have something like CasLoginPayloadData
?
import chat.rocket.core.internal.model.UserPayload | ||
import chat.rocket.core.internal.model.UsernameLoginPayload | ||
import chat.rocket.core.internal.model.UserPayloadData | ||
import chat.rocket.core.internal.model.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to import all models here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDE auto import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small code stuff, but LGMT.
No description provided.