This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Hotfix/theme conflict bodyStyle variable (body.style attribute) #572 #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
florisvangeel
force-pushed
the
hotfix/theme-conflict
branch
from
89982a2
to
68b6163
Compare
remove the conflict
MartinSchoeler
suggested changes
Sep 13, 2021
yarn.lock
Outdated
| @@ -1,15668 +0,0 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
Could you please undo this deletion? Thanks!
|
why is the lock not in the gitignore? |
|
it should be ok now? |
|
@iDevIT Thanks for the contribution!! I found some issues with this PR while testing. The thing is, scrolling stopped working on mobile devices, as soon a widget was opened and then closed. I believe this was a result of adding these 2 extra CSS attributes to the body -> So, I've created a PR #660 to fix this and also simplified the logic for handling styles by grouping those styles into a single class. Feel free to test the change and share your findings. Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes bodyStyle variable (body.style attribute) #572
#572