[NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic #666

tiagoevanp · 2021-11-29T22:02:30Z

Introduce the logic of Omnichannel/Livechat Livechat_clear_local_storage_when_chat_ended setting

src/lib/room.js

renatobecker · 2021-12-01T13:10:12Z

src/store/Store.js

@@ -77,6 +77,10 @@ export default class Store {
 		this.emit('change', [this._state, prevState, partialState]);
 	}

+	cleanState() {
+		this._state = {};


Just set {} as _state is not enough because this way the token field value won't be recreated, and this is an issue, if you start a new chat and then refresh the page, the chat history is gone.
That's the reason we need to "reset" the default state, the same we do when the local storage is created as you can see here:

Rocket.Chat.Livechat/src/store/index.js

Lines 7 to 39 in 0b50f73

const initialState = {

token: createToken(),

typing: [],

config: {

messages: {},

settings: {},

theme: {},

triggers: [],

departments: [],

resources: {},

},

messages: [],

user: null,

sound: {

src: '',

enabled: true,

play: false,

},

iframe: {

guest: {},

theme: {},

visible: true,

},

gdpr: {

accepted: false,

},

alerts: [],

visible: true,

minimized: true,

unread: null,

incomingCallAlert: null,

ongoingCall: null, // TODO: store call info like url, startTime, timeout, etc here

};

Hey @renatobecker , can you take a look again?

It works like a charm now, but we should not change the following fields as they impact UI/UX.

minimized

visible

undocked

expanded

Changes done!

LGTM, but please check this comment

renatobecker · 2021-12-02T18:07:51Z

src/store/Store.js

@@ -77,6 +77,10 @@ export default class Store {
 		this.emit('change', [this._state, prevState, partialState]);
 	}

+	cleanState() {
+		this._state = {};


It works like a charm now, but we should not change the following fields as they impact UI/UX.

minimized

visible

undocked

expanded

src/lib/room.js

src/store/Store.js

KevLehman · 2021-12-02T19:29:38Z

After store change I had to update storybook, that generated a ton more of changes :(

Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>

* [IMPROVE] Add cookie to identify widget calls (RocketChat#645) * [IMPROVE] Russian translations (RocketChat#644) Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * [IMPROVE] Spanish translations (RocketChat#370) * Full Spanish translation * Update es.json corrected: "invalid_email_e82f3682" Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * [FIX] Escaping HTML on paste/drop Text (RocketChat#471) Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * [IMPROVE] Swedish Translations (RocketChat#573) Added some translations Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * [IMPROVE] Readme enhancements (RocketChat#557) * new steps to run your local widget correctly * remove screenshot from repository * Update README.md Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * Release 1.9.5 * [FIX] 'Hide agent info' not working on system message (RocketChat#651) * Fix 'Hide agent info' not working on chat transfer message * Fix 'Hide agent info' setting not working on move chat to queue sytem msg * update storybook * Remove i18n fixes * [FIX] Issues on Custom Livechat messages (RocketChat#648) * Couple of fixes wrt custom messages - Fix offline success messages not working - Support HTML content on Offline message label * Support markdown data on Instructions panel * Update storybook * Release 1.9.6 * [NEW] Audio and Video calling in Livechat using WebRTC RocketChat#646 * add callnotification,msg,iframe code * fix eslint issues * fix eslint file path issues * fix stylelint issues * done ui changes * add icons and improve ui * fix error * remove-icons * add icons * add i18n.t, change classname, improve ui * remove font-family * change iframe link * add check for jitsi * add jitsi link * add time message in system message and add catch * display alert, change function name * Improve overall codebase * Convert tabs to spaces for translation file * Accept jitsi url info from the message and remove dependency from Livechat.videoCall endpoint * Update index.js * add message in i18n file Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> add joinCallBtn, endCall message, callRing functionalities. (RocketChat#618) * add callnotification,msg,iframe code * fix eslint issues * fix eslint file path issues * fix stylelint issues * done ui changes * add join call button * add icons and improve ui * fix error * remove-icons * add icons * ui changes * add icon and timeout functionality * add I18n.t * add i18n.t, change classname, improve ui * remove font-family * change iframe link * add check for jitsi * add jitsi link * add time message in system message and add catch * display alert, change function name * Improve overall codebase * Convert tabs to spaces for translation file * Accept jitsi url info from the message and remove dependency from Livechat.videoCall endpoint * Update index.js * add message in i18n file * add joincall btn, call time, timeout * fix lint error * Update ShowJoinCallButton.js * fix conflicts * improve codebase * fix bugs * update some files * improve css, codebase and change condition * add correct link for iframe and joinCallBtn, show correct time * update call status at rc-core * update api file * rebase file * change link, use store class * update callIframe file * handle corner cases * remove file * Update room.js file Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> * update one file * revert roomjs file * add common condition in room.js file Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> [NEW] Handle endCall and expandView control buttons (RocketChat#633) * [NEW] Handle endCall and expandView control buttons * [FIX] Lint errors * [FIX] Join Call Button giving call ended even when call inProgress * [FIX] slash omitted in the url * [REF] Remove redundant async keyword * [REF] Use spread operator, set ongoingCall status when expanding * [FIX] String enclosed within double quotes Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> * [FIX] ongoingCall variable not destructured but used Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> [FIX] Notify agent on call decline (RocketChat#634) [NEW] WebRTC-call in new tab for mobile devices (RocketChat#629) * open webrtc call in new tab for mobile devices * improve codebase * add helper function * update one file * checking call status from room object * update one file * handle refresh case * change message filter condition Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> [NEW] add-jitsi-call-support Co-Authored-By: Deepak Agarwal <56799414+Deepak-learner@users.noreply.github.com> Improve overall codebase - Define an enum like structure for call statuses - Fix formatting and spelling issues - General refactoring update Rocket.Chat.js.SDK version to 1.0.0-alpha.42 Fix Join call button layout Fix typo Apply review suggestions - Use date-fns library to calculate call duration Refactor Call Statuses to remove redundancy Rename endTs property on Message to webRtcCallEndTs * [FIX] LoadConfig after registering guest (RocketChat#640) * [FIX] Body styles getting overridden RocketChat#660 * Release 1.10.0 * Chore: Add PR title check (RocketChat#663) * [NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic (RocketChat#666) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> * [IMPROVE] Change logic to generate token on Live Chat * [NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic (RocketChat#666) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> * [IMPROVE] Change logic to generate token on Live Chat * Release 1.11.0 * Hide Livechat if omnichannel is disabled (RocketChat#671) * Release 1.11.1 (RocketChat#672) * Hide Livechat if omnichannel is disabled (RocketChat#671) * Release 1.11.1 Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> * [FIX] IME not working properly (RocketChat#674) * parse when submit only * fix storybook * Release 1.11.2 (RocketChat#675) * Merge develop into master * Update build files * Update loki references * Update build files * [NEW] Introduce Widget API method to manage Business Units (RocketChat#677) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * [fa] Update FA translations (RocketChat#653) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> * Release 1.12.0 (RocketChat#680) * [NEW] Introduce Widget API method to manage Business Units (RocketChat#677) * [IMPROVE] Update FA translations (RocketChat#653) * Fix clearLocalStorageWhenChatEnded * Update build files * Update build files * Update pr-title-checker-config.json Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Vladislavs Stashkevichs <n4rayane@gmail.com> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Miguel Salcedo <imiguelsalcedo@gmail.com> Co-authored-by: Shailesh Baldaniya <shaileshbaldaniya351@gmail.com> Co-authored-by: gridnine-developer <81713520+gridnine-developer@users.noreply.github.com> Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Ariel Barreiro <abarrei@gmail.com> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Cauê Felchar <11652381+cauefcr@users.noreply.github.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: shamsnaamir <54275157+shamsnaamir@users.noreply.github.com>

commit 43f9682 Author: Cauê Felchar <11652381+cauefcr@users.noreply.github.com> Date: Fri Apr 8 17:49:04 2022 -0300 [FIX] Prevent html rendering on messages (#701) commit 56ed044 Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Sat Apr 2 00:11:42 2022 -0300 Chore: Update cd.yml (#704) commit f41cd48 Merge: 1cb7ae4 efa1456 Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Fri Apr 1 23:14:48 2022 -0300 Merge branch 'master' into develop commit 1cb7ae4 Author: Tasso Evangelista <tasso.evangelista@rocket.chat> Date: Fri Apr 1 00:39:47 2022 -0300 Chore: Replace `a / b` with `math.div(a, b)` on SCSS files (#702) commit 7e6ff4b Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Fri Apr 1 00:00:25 2022 -0300 [IMPROVE] Add TypeScript (#694) commit 6a16d3b Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Thu Mar 31 12:41:18 2022 -0300 [IMPROVE] Replace i18n package (#657) commit 3cc106a Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Tue Mar 29 22:54:37 2022 +0530 [FIX] Revert: LoadConfig after registering guest (#696) commit f3b8fbe Author: Cauê Felchar <11652381+cauefcr@users.noreply.github.com> Date: Fri Mar 25 16:40:16 2022 -0300 [FIX] Fixes broken triggers. (#695) * updated beginning of the file. * 1 fixed, 1 working, 1 to go * all working 🎉 commit fb1b2ee Author: Cauê Felchar <11652381+cauefcr@users.noreply.github.com> Date: Fri Mar 25 10:45:48 2022 -0300 [IMPROVE] Centralized e-mail validation under a library function (#693) * Centralized e-mail regex usage * moved constants out of the function commit 12225f8 Author: Cauê Felchar <11652381+cauefcr@users.noreply.github.com> Date: Tue Mar 8 15:27:12 2022 -0300 [FIX] Making sure the 'hide agent info' hides the agent info even with department change. (#688) * don't show agent name when setting disallows it commit c04dcea Merge: ca2d04e a0c38c9 Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Thu Jan 20 11:39:40 2022 -0300 Merge branch 'master' of github.com:RocketChat/Rocket.Chat.Livechat into develop commit ca2d04e Merge: 8da8b8b 1ee9420 Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Thu Jan 20 11:09:05 2022 -0300 Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.Livechat into develop commit 1ee9420 Author: shamsnaamir <54275157+shamsnaamir@users.noreply.github.com> Date: Thu Jan 20 17:29:35 2022 +0330 [fa] Update FA translations (#653) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> commit d95ae3d Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Thu Jan 20 19:14:15 2022 +0530 [NEW] Introduce Widget API method to manage Business Units (#677) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> commit 8da8b8b Merge: b5f0cce 43b0404 Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Fri Jan 14 15:26:00 2022 -0300 Merge branch 'master' into develop commit b5f0cce Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Fri Jan 7 17:39:59 2022 -0300 [FIX] IME not working properly (#674) * parse when submit only * fix storybook commit 27ed909 Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Fri Dec 31 00:42:24 2021 +0530 Hide Livechat if omnichannel is disabled (#671) commit 305939d Author: Cauê Felchar <11652381+cauefcr@users.noreply.github.com> Date: Wed Dec 8 17:26:58 2021 -0300 [IMPROVE] Change logic to generate token on Live Chat commit 4c1777f Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Fri Dec 3 11:00:16 2021 -0300 [NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic (#666) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> commit 0b50f73 Author: Kevin Aleman <kevin.aleman@rocket.chat> Date: Mon Nov 22 09:29:40 2021 -0600 Chore: Add PR title check (#663) commit 760fcf5 Author: Ariel Barreiro <abarrei@gmail.com> Date: Fri Nov 19 16:08:18 2021 -0300 [FIX] LoadConfig after registering guest (#640) commit f7c3363 Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Sat Nov 20 00:37:28 2021 +0530 [FIX] Undo Css changes (#661) commit 66c7a13 Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Fri Nov 19 20:54:21 2021 +0530 Fixes #572 - Body styles getting overridden (#660) * Fixes #572 - Body styles getting overriden * Fix build commit b65502e Merge: cb24408 f08bd01 Author: Kevin Aleman <kevin.aleman@rocket.chat> Date: Fri Nov 19 07:45:20 2021 -0600 Merge pull request #646 from RocketChat/livechat-calls-fix-conflicts [NEW] Audio and Video calling in Livechat using WebRTC commit f08bd01 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Fri Nov 19 16:20:15 2021 +0530 Rename endTs property on Message to webRtcCallEndTs commit 747142f Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Fri Nov 19 01:35:33 2021 +0530 Refactor Call Statuses to remove redundancy commit 6993764 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Thu Nov 18 18:24:56 2021 +0530 Apply review suggestions - Use date-fns library to calculate call duration commit d134a28 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Mon Oct 18 14:50:58 2021 +0530 Fix typo commit 8daee44 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Mon Oct 18 13:42:33 2021 +0530 Fix Join call button layout commit c0962e8 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Mon Oct 18 12:30:22 2021 +0530 update Rocket.Chat.js.SDK version to 1.0.0-alpha.42 commit 2150c96 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Mon Sep 20 21:18:26 2021 +0530 Improve overall codebase - Define an enum like structure for call statuses - Fix formatting and spelling issues - General refactoring commit 2d2ca32 Author: murtaza98 <murtaza.patrawala@rocket.chat> Date: Tue Sep 14 18:01:52 2021 +0530 [NEW] add-jitsi-call-support Co-Authored-By: Deepak Agarwal <56799414+Deepak-learner@users.noreply.github.com> commit 5820ea5 Author: Deepak Agarwal <deepak710agarwal@gmail.com> Date: Thu Aug 19 21:30:47 2021 +0530 [NEW] WebRTC-call in new tab for mobile devices (#629) * open webrtc call in new tab for mobile devices * improve codebase * add helper function * update one file * checking call status from room object * update one file * handle refresh case * change message filter condition Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> commit 853399d Author: Dhruv Jain <51796498+djcruz93@users.noreply.github.com> Date: Tue Aug 17 23:11:19 2021 +0530 [FIX] Notify agent on call decline (#634) commit b52f484 Author: Dhruv Jain <51796498+djcruz93@users.noreply.github.com> Date: Tue Aug 17 17:11:59 2021 +0530 [NEW] Handle endCall and expandView control buttons (#633) * [NEW] Handle endCall and expandView control buttons * [FIX] Lint errors * [FIX] Join Call Button giving call ended even when call inProgress * [FIX] slash omitted in the url * [REF] Remove redundant async keyword * [REF] Use spread operator, set ongoingCall status when expanding * [FIX] String enclosed within double quotes Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> * [FIX] ongoingCall variable not destructured but used Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> commit a02f241 Author: Deepak Agarwal <deepak710agarwal@gmail.com> Date: Mon Aug 9 15:34:37 2021 +0530 add joinCallBtn, endCall message, callRing functionalities. (#618) * add callnotification,msg,iframe code * fix eslint issues * fix eslint file path issues * fix stylelint issues * done ui changes * add join call button * add icons and improve ui * fix error * remove-icons * add icons * ui changes * add icon and timeout functionality * add I18n.t * add i18n.t, change classname, improve ui * remove font-family * change iframe link * add check for jitsi * add jitsi link * add time message in system message and add catch * display alert, change function name * Improve overall codebase * Convert tabs to spaces for translation file * Accept jitsi url info from the message and remove dependency from Livechat.videoCall endpoint * Update index.js * add message in i18n file * add joincall btn, call time, timeout * fix lint error * Update ShowJoinCallButton.js * fix conflicts * improve codebase * fix bugs * update some files * improve css, codebase and change condition * add correct link for iframe and joinCallBtn, show correct time * update call status at rc-core * update api file * rebase file * change link, use store class * update callIframe file * handle corner cases * remove file * Update room.js file Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> * update one file * revert roomjs file * add common condition in room.js file Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> commit 14c4d17 Author: Deepak Agarwal <deepak710agarwal@gmail.com> Date: Thu Jul 22 20:05:55 2021 +0530 add callnotification,callStartmsg,iframe code (#617) * add callnotification,msg,iframe code * fix eslint issues * fix eslint file path issues * fix stylelint issues * done ui changes * add icons and improve ui * fix error * remove-icons * add icons * add i18n.t, change classname, improve ui * remove font-family * change iframe link * add check for jitsi * add jitsi link * add time message in system message and add catch * display alert, change function name * Improve overall codebase * Convert tabs to spaces for translation file * Accept jitsi url info from the message and remove dependency from Livechat.videoCall endpoint * Update index.js * add message in i18n file Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> commit cb24408 Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Wed Oct 20 23:30:21 2021 +0530 [FIX] 'Hide agent info' not working on system message (#651) * Fix 'Hide agent info' not working on chat transfer message * Fix 'Hide agent info' setting not working on move chat to queue sytem msg * update storybook * Remove i18n fixes commit cb0695c Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Wed Oct 20 22:25:30 2021 +0530 [FIX] Issues on Custom Livechat messages (#648) * Couple of fixes wrt custom messages - Fix offline success messages not working - Support HTML content on Offline message label * Support markdown data on Instructions panel * Update storybook commit 663a574 Author: Rafael Ferreira <rafaelblink@gmail.com> Date: Tue Sep 14 15:34:39 2021 -0300 [IMPROVE] Readme enhancements (#557) * new steps to run your local widget correctly * remove screenshot from repository * Update README.md Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> commit 7d2a875 Author: gridnine-developer <81713520+gridnine-developer@users.noreply.github.com> Date: Tue Sep 14 21:30:06 2021 +0300 [IMPROVE] Swedish Translations (#573) Added some translations Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> commit 8bc8c25 Author: Shailesh Baldaniya <shaileshbaldaniya351@gmail.com> Date: Tue Sep 14 23:58:28 2021 +0530 [FIX] Escaping HTML on paste/drop Text (#471) Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> commit a48a85b Author: Miguel Salcedo <imiguelsalcedo@gmail.com> Date: Tue Sep 14 15:27:21 2021 -0300 [IMPROVE] Spanish translations (#370) * Full Spanish translation * Update es.json corrected: "invalid_email_e82f3682" Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> commit 2f120ea Author: Vladislavs Stashkevichs <n4rayane@gmail.com> Date: Tue Sep 14 20:31:16 2021 +0300 [IMPROVE] Russian translations (#644) Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> commit 02b4d33 Author: Kevin Aleman <kevin.aleman@rocket.chat> Date: Tue Sep 14 11:08:25 2021 -0600 [IMPROVE] Add cookie to identify widget calls (#645) commit 0ae132a Merge: 63d1c5b 61986eb Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Fri Aug 20 11:22:18 2021 -0300 Merge branch 'master' into develop commit 63d1c5b Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Date: Thu Aug 19 21:45:48 2021 -0300 [FIX] Iframe overlay (#631) * update widget height when triggered * fix state * fix lint error * fix * css fix * Lint me up inside Co-authored-by: Martin <martin.schoeler@rocket.chat> commit 231e25a Author: front-stream <contact@front-stream.com> Date: Wed Aug 18 17:15:57 2021 +0200 [NEW] German informal translation (#622) * German informal translation * Rename de_informal.json to de_IN.json Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> commit bfd9fa3 Author: José Zadir Ferreira Neto <jzadir@gmail.com> Date: Wed Aug 18 12:15:16 2021 -0300 Ajustanto erro na tradução de department (#632) commit 34eed05 Author: silaslubberink <82575625+silaslubberink@users.noreply.github.com> Date: Tue Aug 17 16:28:21 2021 +0200 Update translation (#601) A few fields were not yet translated. Corrected some translation errors. commit 4f60b93 Author: Billy Noah <billynoah@gmail.com> Date: Tue Aug 3 17:29:49 2021 -0400 [IMPROVE] Open links in another tab on Livechat widget (#610) prevent target attribute from being removed by sanitizer commit 5498c56 Merge: 75b2429 fa5658b Author: Guilherme Gazzo <guilherme@gazzo.xyz> Date: Wed Apr 21 00:34:37 2021 -0300 Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.Livechat into develop commit fa5658b Author: Deepak Agarwal <deepak710agarwal@gmail.com> Date: Wed Apr 21 09:02:55 2021 +0530 [FIX] sound notification on/off (#567) commit ef84f8b Author: sctEdwin <72842751+sctEdwin@users.noreply.github.com> Date: Wed Apr 21 05:52:27 2021 +0900 [FIX] Invalid font size for hiragana and katakana (#559) * fix hiragana katakana from being treated as emoji * fix ime conversion problem * inputLock as state * do not directly mutate state setState outside to keep render function pure * Update src/components/Composer/index.js Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> * Update src/components/Composer/index.js Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> * Update src/components/Composer/index.js Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> * Update src/components/Composer/index.js Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> * Update src/components/Composer/index.js Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> * fixed ESLint error * improve naming 2 Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com>

tiagoevanp added 2 commits November 29, 2021 18:27

clear session when clearLivechatUserSession is true

95f46f5

adjust name

84c6640

renatobecker reviewed Nov 30, 2021

View reviewed changes

src/lib/room.js Outdated Show resolved Hide resolved

clean localStorage instead removeVisitor

7231db8

tiagoevanp mentioned this pull request Dec 1, 2021

[NEW] Create new setting to clean local storage at end of chats RocketChat/Rocket.Chat#23821

Merged

tiagoevanp changed the title ~~[NEW] Handle with removeGuestInfoWhenChatEnded setting~~ [NEW] Introduce clearLocalStorageWhenChatEnded setting logic Dec 1, 2021

renatobecker suggested changes Dec 1, 2021

View reviewed changes

reset initial state when chat is closed

909197d

KevLehman requested a review from MartinSchoeler December 2, 2021 17:50

renatobecker suggested changes Dec 2, 2021

View reviewed changes

src/lib/room.js Outdated Show resolved Hide resolved

exclude UI impacting flags

0a6db78

renatobecker suggested changes Dec 2, 2021

View reviewed changes

src/store/Store.js Outdated Show resolved Hide resolved

KevLehman added 2 commits December 2, 2021 13:04

remove unused change

01cc8c7

why

6e84db1

KevLehman requested a review from renatobecker December 2, 2021 19:36

renatobecker approved these changes Dec 2, 2021

View reviewed changes

KevLehman merged commit 4c1777f into develop Dec 3, 2021

KevLehman deleted the new/clear-user-session branch December 3, 2021 14:00

casalsgh added this to the 4.2.1 milestone Dec 8, 2021

MartinSchoeler added a commit that referenced this pull request Dec 9, 2021

[NEW] Introduce clearLocalStorageWhenChatEnded setting logic (#666)

9226ab2

Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>

MartinSchoeler mentioned this pull request Dec 9, 2021

Release 1.11.0 #668

Merged

sampaiodiego mentioned this pull request Dec 10, 2021

Release 4.2.1 RocketChat/Rocket.Chat#23917

Merged

murtaza98 mentioned this pull request Dec 13, 2021

Reset hook to clear internal state and go back to a first loaded state #628

Open

MartinSchoeler mentioned this pull request Mar 27, 2024

LiveChat: Showing registration form after ending the chat RocketChat/Rocket.Chat#9142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic #666

[NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic #666

tiagoevanp commented Nov 29, 2021 •

edited

renatobecker Dec 1, 2021

KevLehman Dec 2, 2021

renatobecker Dec 2, 2021

KevLehman Dec 2, 2021

renatobecker Dec 2, 2021

renatobecker Dec 2, 2021

KevLehman commented Dec 2, 2021

	const initialState = {
	token: createToken(),
	typing: [],
	config: {
	messages: {},
	settings: {},
	theme: {},
	triggers: [],
	departments: [],
	resources: {},
	},
	messages: [],
	user: null,
	sound: {
	src: '',
	enabled: true,
	play: false,
	},
	iframe: {
	guest: {},
	theme: {},
	visible: true,
	},
	gdpr: {
	accepted: false,
	},
	alerts: [],
	visible: true,
	minimized: true,
	unread: null,
	incomingCallAlert: null,
	ongoingCall: null, // TODO: store call info like url, startTime, timeout, etc here
	};

[NEW] Introduce clearLocalStorageWhenChatEnded setting logic #666

[NEW] Introduce clearLocalStorageWhenChatEnded setting logic #666

Conversation

tiagoevanp commented Nov 29, 2021 • edited

renatobecker Dec 1, 2021

Choose a reason for hiding this comment

KevLehman Dec 2, 2021

Choose a reason for hiding this comment

renatobecker Dec 2, 2021

Choose a reason for hiding this comment

KevLehman Dec 2, 2021

Choose a reason for hiding this comment

renatobecker Dec 2, 2021

Choose a reason for hiding this comment

renatobecker Dec 2, 2021

Choose a reason for hiding this comment

KevLehman commented Dec 2, 2021

[NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic #666

[NEW] Introduce `clearLocalStorageWhenChatEnded` setting logic #666

tiagoevanp commented Nov 29, 2021 •

edited