Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] other login methods are offered on SAML only login, SAML login button not colored #1377

Closed
localguru opened this issue Nov 10, 2019 · 10 comments

Comments

@localguru
Copy link

localguru commented Nov 10, 2019

Describe the bug

Although a RC server only allows SAML as authentication method, the app offers the login via e-mail or the creation of an account.

The button of the SAML login is not colored in the configured color. The color of the SAML button is white, so that it is not perceived as a button, but as a hint text. This is a very misleading user guidance!

To Reproduce

Screenshot_20191110-175652

Devices and Versions

Your Rocket.Chat.Android version: 4.0.4, 4.0.5, 4.1.0
Your Rocket.Chat Server version: 2.2.0 bundle installation

Mobile device model and OS version: OnePlus 7 Android 10

Additional context

Browser offeres SAML only, color of SAML button is displayed correctly.

@sampaiodiego sampaiodiego transferred this issue from RocketChat/Rocket.Chat.Android Nov 11, 2019
@localguru localguru changed the title BUG: other login methods are offered on SAML only login, SAML login button not colored [BUG] other login methods are offered on SAML only login, SAML login button not colored Nov 15, 2019
rasos added a commit to rasos/Rocket.Chat.ReactNative that referenced this issue Nov 16, 2019
@localguru
Copy link
Author

still in version 4.1.0

@mddvul22
Copy link

Anyway to escalate this issue. I would think that any piece of software that shows two login buttons would want to fix that kind of bug.

@localguru
Copy link
Author

Anything new on it? It confuses my users more and more, especially since the Shibboleth button is only highlighted in white.

@diegolmello
Copy link
Member

I was hoping someone from the community would fix it, as it's very easy to implement.
Since nobody did it, let's schedule for 4.4.0 and I'll do it myself.

@localguru
Copy link
Author

localguru commented Feb 21, 2020

@diegolmello Is there already a schedule for a fix? We receive several requests daily from users who overlook the button for login via Shibboleth and try to use their email address or think they need to create an account. This is extremely confusing for normal users. It also makes no sense to offer other authentication methods if the server only offers Sibboleth/SAML and no account creation. It would be great if you could fix it soon.

@diegolmello
Copy link
Member

@localguru It was fixed yesterday on #1727. I'll release a beta for Experimental later today.

@localguru
Copy link
Author

@diegolmello This is great, even with the color of the button! Thank you, Diego!

@diegolmello
Copy link
Member

Kudos to @djorkaeffalexandre (:

@mddvul22
Copy link

mddvul22 commented Mar 4, 2020

In what version of the stable mobile app should this be appearing? I have 4.4.0.2107 and am still seeing the problem. I assume the fix is coming in the next version?

@diegolmello
Copy link
Member

@mddvul22 Official beta coming next Monday. It's on Experimental beta if you want to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants