Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket.chat mobile application does not mark channels as read #2519

Closed
Gummikavalier opened this issue Oct 5, 2020 · 11 comments · Fixed by #2567 or #2636
Closed

Rocket.chat mobile application does not mark channels as read #2519

Gummikavalier opened this issue Oct 5, 2020 · 11 comments · Fixed by #2567 or #2636

Comments

@Gummikavalier
Copy link

Description:

Recently we've had a constant issue that on both iOS and Android mobile app does not mark any new unread channels as read after visiting them in the mobile client. The situation gets fixed either by closing the app from the history, or clearing its local cache.

Environment Information:

  • Rocket.Chat Server Version: 3.6.3
  • Rocket.Chat App Version: 4.11 and 4.10
  • Device Name: Android and iOS
  • OS Version: latest

Steps to reproduce:

  1. Go to RC app and sort messages by activity and unread on top.
  2. Click any new unread channels under unread list.
  3. Go back to channels view
  4. Also try marking unread channel as read

Expected behavior:

A read channel should be removed from the list of unread channels

Actual behavior:

A read channel stays under unread channels list

Additional context:

We have noticed this issue with two separate RC server instances / workspaces. Both of them have push notifications disabled, so it might be related to late changes to notification handling on the mobile client.

Other possible triggering factor could be changes in the app to cache more data locally on the client end.

@diegolmello
Copy link
Member

diegolmello commented Oct 5, 2020

It might be related to new threads support.
We're going to implement it on 4.12.0.

I'm marking as a bug anyway, because I might be wrong and it's something else.

@ankar84
Copy link
Contributor

ankar84 commented Oct 5, 2020

It might be related to new threads support.
We're going to implement it on 4.12.0.

I'm marking as a bug anyway, because I might be wrong and it's something else.

I think you rigth. I see this with new threads on 3.6.3 server

@bestog
Copy link

bestog commented Oct 12, 2020

We have the Same Problem.

@zaphod534
Copy link
Contributor

Same problem here:

  • Server version: 3.0.10

  • App version: 4.11

The only way to mark a channel as read is to close and reopen app.

@zaphod534
Copy link
Contributor

zaphod534 commented Oct 16, 2020

Update:
I notice that when a new message is sent on a channel, it is marked as unread, but it still appears in unread group. If I toggle "Unread on top" option twice the channel correctly disappears from the unread list.

@diegolmello diegolmello self-assigned this Oct 19, 2020
@diegolmello diegolmello mentioned this issue Oct 19, 2020
10 tasks
@Gummikavalier
Copy link
Author

Hi! This issue seems still to be active in 4.12; read messages still stay under Unread header. I can see that the font loses bolding (not very easy to spot with this font), but they don't clean up immediately. Possibly when checking new messages few minutes later they have moved away from the Unread.

@diegolmello
Copy link
Member

@Gummikavalier Can you post a gif/video?

@zdumitru
Copy link

zdumitru commented Nov 9, 2020

@diegolmello Yes, I also confirm that behaviour. Tested on 4.12.0.21382 version.

Screenshot_20201109-130150_RocketChat Experimental

If you look on the screen, the top channel has been read, but still stays in the "Unread" section. Even though it is not bold anymore. This is a bug and the issue should be reopened. Or a new issue opened.

@Gummikavalier
Copy link
Author

@diegolmello Yes, exactly how @zdumitru has it in his pic. The message does get marked as read, but it just doesn't disappear from under the Unread.

@diegolmello diegolmello reopened this Nov 9, 2020
diegolmello added a commit that referenced this issue Nov 12, 2020
diegolmello added a commit that referenced this issue Nov 12, 2020
* Fix parent title on thread header breaking lines

* Fix #2519

* Fix thread badge not being updated
@Gummikavalier
Copy link
Author

Confirmed working, thanks a lot! 👍

@bestog
Copy link

bestog commented Nov 16, 2020

Good Job. Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment