Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Show thumbnails in message view #2975

Merged
merged 8 commits into from
Aug 27, 2021

Conversation

sumukhah
Copy link
Contributor

@sumukhah sumukhah commented Mar 11, 2021

Proposed changes

Added thumbnail views in messages.

Issue(s)

fixes: #2853

How to test or reproduce

Add a message thumbnail and test in the message list

Screenshots

Screenshot 2021-03-11 at 6 48 43 PM

{
    "message": {
        "rid": "XMqEKWyZcvxZPsWLX",
        "attachments": [
            {
                "title": "Joker",
                "text": "**Recommender:**  + recommender + \n\n**Rating:**    + rating + /10 based on  + votecount +  votes.\n**Released:**  + releasedate + \n\n**Overview:**  + overview",
                "thumb_url": "https://images-na.ssl-images-amazon.com/images/I/71jKxPAMFbL._AC_SL1500_.jpg",
                "color": "#FFD700",
                "title_link": "https://www.imdb.com/title/tt7286456/"
            }
        ]
    }
}

126699187-882f9c26-ddab-4e99-bc94-336fa0327c47.png

Screenshot 2021-03-11 at 7 03 16 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Some snapshot tests have failed in my local setup. I believe it is ok but I am not familiar with snapshot tests. So please tell me if any thing needs to be changed

@diegolmello
Copy link
Member

@sumukhah Thanks! Can you write stories for your change?

@sumukhah
Copy link
Contributor Author

Sure 👍

@sumukhah
Copy link
Contributor Author

Added stories on thumbnails,

Screenshot 2021-03-12 at 12 28 38 PM

@diegolmello should I update the snapshots?

@diegolmello
Copy link
Member

@sumukhah Yes, run yarn test-update to make lint job to succeed.

@sumukhah
Copy link
Contributor Author

sumukhah commented Apr 6, 2021

@diegolmello
Could you review this PR? I have added the snapshots

@reinaldonetof
Copy link
Contributor

@sumukhah Can you resolve the conflicts? Thanks!

@reinaldonetof
Copy link
Contributor

Hi, sumukhah, I resolved the conflicts. So, LGTM!

Thanks for your contribution

Copy link
Contributor

@reinaldonetof reinaldonetof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App does not show thumbnail and attachment-title
5 participants