-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Show thumbnails in message view #2975
Conversation
aee3079
to
0bc4261
Compare
@sumukhah Thanks! Can you write stories for your change? |
Sure 👍 |
Added stories on thumbnails, @diegolmello should I update the snapshots? |
@sumukhah Yes, run |
94a4bca
to
8baa78c
Compare
8baa78c
to
f6db9a6
Compare
71ccc4b
to
3cab45f
Compare
@diegolmello |
@sumukhah Can you resolve the conflicts? Thanks! |
Hi, sumukhah, I resolved the conflicts. So, LGTM! Thanks for your contribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Added thumbnail views in messages.
Issue(s)
fixes: #2853
How to test or reproduce
Add a message thumbnail and test in the message list
Screenshots
Types of changes
Checklist
Further comments
Some snapshot tests have failed in my local setup. I believe it is ok but I am not familiar with snapshot tests. So please tell me if any thing needs to be changed