Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Evaluate values in handle failure #3235

Merged
merged 19 commits into from
Aug 27, 2021

Conversation

reinaldonetof
Copy link
Contributor

Proposed changes

Check if there are the params within the object err before calling them. Add this, some params were inserted in i18n.

Issue(s)

app/sagas/createChannel.js:113

  • TypeError · Cannot read property 'channel_name' of undefined
  • TypeError · Cannot read property 'errorType' of undefined

How to test or reproduce

  • During Create Channel or Create Team and receive errors

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

app/sagas/createChannel.js Outdated Show resolved Hide resolved
app/sagas/createChannel.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gerzonc gerzonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reinaldonetof reinaldonetof self-assigned this Jul 16, 2021
app/sagas/createChannel.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gerzonc gerzonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit f838825 into develop Aug 27, 2021
@diegolmello diegolmello deleted the fix.evaluate-vals-handle-failure-bugsnag branch August 27, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants