Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Run lint and tests on staged files only #3291

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Chore: Run lint and tests on staged files only #3291

merged 1 commit into from
Jul 22, 2021

Conversation

gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Jul 22, 2021

Proposed changes

Run lint and tests on staged files only instead of all the files

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Jul 22, 2021
AlexAlexandre
AlexAlexandre approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR revised and approved, ready to be merged.

@diegolmello diegolmello merged commit 97ed3a6 into develop Jul 22, 2021
@diegolmello diegolmello deleted the chore.run-lint-tests-staged-only branch July 22, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAlexandre AlexAlexandre AlexAlexandre approved these changes

Assignees

@gerzonc gerzonc

Labels
🚚 chore 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gerzonc @AlexAlexandre @diegolmello