Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Permissions to edit livechat when the user is a livechat-agent #3294

Merged
merged 5 commits into from
Aug 23, 2021

Conversation

reinaldonetof
Copy link
Contributor

Proposed changes

Last month the way that the API permit a user to edit the livechat was changed to 'edit-omnichannel-contact', because that was occurring a bug when the agent wants to edit something.

Issue(s)

The same agent could edit a livechat on the web, but on the mobile app couldn't

How to test or reproduce

1 - Activate Omnicahnnel -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-admins-guide
3 - Start a new chat through Livechat https://multiverse.rocket.chat/livechat
4 - Go to Omnichannel Queue (Mobile)
5 - Open an incoming chat
6 - Click on the title
7- At Actions screen click on name of the user
8 - Will appear the edit button

Screenshots

Before After

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@AlexAlexandre AlexAlexandre self-requested a review August 2, 2021 20:45
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants