-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for tasks and unordered list markdown #5057
Conversation
Hey @diegolmello and @GleidsonDaniel , please have a look at the PR. |
@GleidsonDaniel please have a look at it. |
A quick comment, instead add a new library to the repo, can you use it the same way as other places? As you can see here: Rocket.Chat.ReactNative/app/containers/MessageBox/index.tsx Lines 1119 to 1124 in 2d07b16
|
@imf-ali i think this is the best approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change your PR following the pattern commented by @reinaldonetof
Changes done. Please have a look @GleidsonDaniel @reinaldonetof . |
@GleidsonDaniel comment addressed. Please have a look. |
I saw that you sent me a private message asking for the review. |
Oh, sorry for the inconvenience. Will make sure next time, all the checks are successful. I have addressed the remaining comments. Kindly take a look once. |
Issue(s)
Tasks and unordered list does not appear in correct format as that in RC web app.
How to test or reproduce
Screenshots
Previous behaviour
Improvement
Types of changes
Checklist
Further comments
Fix #4927