Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: save different files with the same name and extension #5171

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Aug 17, 2023

Proposed changes

Besides save different files with the same name and extension, we are fixing a bug found that after completing the download, the download queue wasn't deleting that specific download from the queue.

Issue(s)

How to test or reproduce

  • Upload different files with exactly the same name and extension
  • should cache correctly each one

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-897

@reinaldonetof reinaldonetof self-assigned this Aug 17, 2023
@reinaldonetof reinaldonetof mentioned this pull request Aug 17, 2023
10 tasks
@diegolmello diegolmello merged commit fba1419 into develop Aug 18, 2023
14 of 18 checks passed
@diegolmello diegolmello deleted the fix.different-files-with-the-same-name branch August 18, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants