feat: New message composer #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # __tests__/containers/RoomItem/__snapshots__/RoomItem.stories.storyshot # app/lib/constants/colors.ts # e2e/tests/room/02-room.spec.ts # e2e/tests/room/05-threads.spec.ts
Co-authored-by: reinaldonetof <reinaldonetof@hotmail.com>
…h... useCallback isn't really working?
# Conflicts: # .circleci/config.yml # __tests__/containers/Button/__snapshots__/Button.stories.storyshot # __tests__/containers/LoginServices/__snapshots__/LoginServices.stories.storyshot # __tests__/containers/RoomHeader/__snapshots__/RoomHeader.stories.storyshot # __tests__/containers/RoomItem/__snapshots__/RoomItem.stories.storyshot # __tests__/containers/message/__snapshots__/Message.stories.storyshot # __tests__/views/CannedResponsesListView/__snapshots__/CannedResponseItem.stories.storyshot # __tests__/views/ThreadMessagesView/__snapshots__/Item.stories.storyshot # app/containers/ActionSheet/ActionSheet.tsx # app/containers/Status/index.tsx # app/containers/UIKit/UiKitMessage.stories.tsx # app/containers/UIKit/index.tsx # app/containers/message/index.tsx # app/i18n/locales/en.json # app/i18n/locales/pt-BR.json # app/lib/methods/handleMediaDownload.ts # app/lib/services/restApi.ts # app/views/RoomView/List/index.tsx # app/views/RoomView/index.tsx # e2e/tests/room/05-threads.spec.ts # e2e/tests/room/11-autoTranslate.spec.ts # ios/RocketChatRN.xcodeproj/project.pbxproj # jest.setup.js # patches/react-native-ui-lib+7.2.1.patch # yarn.lock
# Conflicts: # app/views/RoomView/List/NavBottomFAB.tsx # app/views/RoomView/List/index.tsx # app/views/RoomView/index.tsx # ios/RocketChatRN.xcodeproj/project.pbxproj
diegolmello
force-pushed
the
feat.new-composer
branch
from
9c0e6c5
to
2af66ec
Compare
diegolmello
force-pushed
the
feat.new-composer
branch
from
d24014c
to
36c2c15
Compare
diegolmello
force-pushed
the
feat.new-composer
branch
from
e25cd85
to
b508213
Compare
diegolmello
force-pushed
the
feat.new-composer
branch
from
e37a983
to
16d00c9
Compare
….ReactNative into feat.new-composer
GleidsonDaniel
approved these changes
Jan 16, 2024
| return ( | ||
| <> | ||
| <BaseButton | ||
| onPress={() => editCancel?.()} |
There was a problem hiding this comment.
Suggested change
| onPress={() => editCancel?.()} | |
| onPress={editCancel} |
| return null; | ||
| } | ||
|
|
||
| // TODO: Use RNGH |
| backgroundColor: colors.buttonBackgroundPrimaryDefault | ||
| } | ||
| ]} | ||
| onPress={() => onPress()} |
There was a problem hiding this comment.
Suggested change
| onPress={() => onPress()} | |
| onPress={onPress} |
|
bug when inserting emojis within multiple characters: |
|
This is not a bug, however this "jump" that occurs when clicking on the input could be avoided if you disabled the input and only focused when clicking on it. |
diegolmello
force-pushed
the
feat.new-composer
branch
from
b79f8df
to
be981d5
Compare
# Conflicts: # __tests__/containers/message/__snapshots__/Message.stories.storyshot # app/lib/constants/colors.ts
# Conflicts: # app/containers/MessageBox/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
Closes #5301
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments