feat: display language icon for auto translated msgs #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diegolmello I've fixed the issue sir. Could you please take a look when you have a chance? Let me know if there are any further changes needed. Thanks. |
diegolmello
previously requested changes
Dec 26, 2023
| import { themes } from '../../../../lib/constants'; | ||
| import styles from '../../styles'; | ||
|
|
||
| const Translated = memo(({ isTranslated }: { isTranslated: boolean }) => { |
There was a problem hiding this comment.
You need to add this component to Storybook
modified: app/containers/message/Message.stories.tsx
|
@reinaldonetof Sir can you review this pr when you are free, Thank you |
reinaldonetof
previously requested changes
Jan 23, 2024
| import styles from '../../styles'; | ||
|
|
||
| const Translated = memo(({ isTranslated }: { isTranslated: boolean }) => { | ||
| const { theme } = useTheme(); |
There was a problem hiding this comment.
Suggested change
| const { theme } = useTheme(); | |
| const { colors } = useTheme(); |
|
|
||
| return ( | ||
| <View style={styles.rightIcons}> | ||
| <CustomIcon name='language' size={16} color={themes[theme].auxiliaryText} /> |
There was a problem hiding this comment.
Suggested change
| <CustomIcon name='language' size={16} color={themes[theme].auxiliaryText} /> | |
| <CustomIcon name='language' size={16} color={colors.auxiliaryText} /> |
|
@reinaldonetof I've made the requested changes sir. Please check it out when you have time, Thanks |
|
@GleidsonDaniel Can you review this pr in your free time? Thanks |
|
Put it before the read receipt |
jsathu07
force-pushed
the
feat.auto_translate_icon
branch
from
e5f6670
to
92d27b6
Compare
GleidsonDaniel
approved these changes
Mar 4, 2024
GleidsonDaniel
dismissed stale reviews from reinaldonetof and diegolmello
outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the message is auto translated, renders the ‘language’ icon on the Message’s RightIcons
Issue(s)
closes #4807
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments