Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show toast msg in members view if direct msg is not allowed #5410

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

jsathu07
Copy link
Contributor

@jsathu07 jsathu07 commented Dec 18, 2023

Proposed changes

When clicking on profile->direct message, in members view action sheet, if direct msg is not allowed user is not told.
I've added toast msg to inform the user for better UX.

Issue(s)

How to test or reproduce

Screenshots

Before

before.mp4

After

after.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

app/views/RoomMembersView/helpers.ts Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@jsathu07
Copy link
Contributor Author

@diegolmello I have implemented the changes you requested. Kindly review the updated code at your convenience sir, Thank you.

@jsathu07
Copy link
Contributor Author

@diegolmello Sir, if there's any updates about this pr feel free to share, I'm ready to commit any changes if necessary.

@diegolmello
Copy link
Member

@jsathu07 description video is outdated

@jsathu07
Copy link
Contributor Author

@diegolmello just updated the description video sir, let me know if there are any changes, thanks.

@jsathu07
Copy link
Contributor Author

@diegolmello Can you please review this pr when you have time, Thanks 🙏

@jsathu07
Copy link
Contributor Author

@GleidsonDaniel Can you review this pr in your free time? Thanks

@GleidsonDaniel GleidsonDaniel merged commit 65e076b into RocketChat:develop Mar 1, 2024
3 of 8 checks passed
@jsathu07 jsathu07 deleted the direct_msg_block branch March 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants