Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve encrypted button on create discussion view #5466

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

SanjaySargam
Copy link
Contributor

Proposed changes

Switch not aligned properly with text Encrypted in CreateDiscussionView

Issue(s)

Fixes #5465

How to test or reproduce

  1. Go to Create New
  2. Click on Discussion
  3. Select a channel or group

Screenshots

WhatsApp Image 2024-01-07 at 12 24 41 AM (1)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@SanjaySargam
Copy link
Contributor Author

Can any moderators please look at this PR

@GleidsonDaniel
Copy link
Contributor

This needs to be validated with the product team, I will send it here on the channel and as soon as they respond I will give feedback.

@GleidsonDaniel
Copy link
Contributor

Just remove the icon and the top and bottom borders.

@SanjaySargam
Copy link
Contributor Author

WhatsApp Image 2024-01-20 at 2 22 29 PM

@SanjaySargam
Copy link
Contributor Author

@GleidsonDaniel Made requested changes. Kindly review it. Thanks!

@GleidsonDaniel GleidsonDaniel changed the title align switch with text feat: improve encrypted button on create discussion view Feb 1, 2024
@GleidsonDaniel GleidsonDaniel changed the title feat: improve encrypted button on create discussion view chore: improve encrypted button on create discussion view Feb 1, 2024
@GleidsonDaniel GleidsonDaniel merged commit 50d534f into RocketChat:develop Feb 1, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch not aligned properly with text "Encrypted" in CreateDiscussionView
2 participants