Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable video call ringer only for direct messages #5472

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Jan 10, 2024

Proposed changes

Disable ringer on group calls, since we don't wait for other user accept the call.

Issue(s)

closes: #5424

How to test or reproduce

  • In any channel, tap to initiate a call

  • Verify the Action Sheet opens

  • Tap “Call”

  • Verify that the user is redirected to the Conference Room

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: VC-142

@GleidsonDaniel GleidsonDaniel changed the title fix: enable video call initiation only for direct messages fix: enable video call ringer only for direct messages Jan 10, 2024
@GleidsonDaniel GleidsonDaniel merged commit c5fe22c into develop Jan 19, 2024
3 of 8 checks passed
@GleidsonDaniel GleidsonDaniel deleted the disable-ringer-channel branch January 19, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ring does not stop
2 participants