Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error when non-support setting change is received via stream #5487

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

GopalVerma1303
Copy link
Contributor

Proposed changes

This pull request adds a check to ensure that the _id being processed in the public-settings-changed event is present in the defaultSettings object before updating the settings. This helps prevent errors when the _id is not part of the default settings.

Issue(s)

Fix #4805 : Error when non-support setting change is received via stream

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@GopalVerma1303
Copy link
Contributor Author

Hey @diegolmello! Please review.

@diegolmello diegolmello changed the title [fix]: Error when non-support setting change is received via stream fix: Error when non-support setting change is received via stream Jan 22, 2024
@diegolmello diegolmello merged commit f7e443a into RocketChat:develop Jan 22, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when non-support setting change is received via stream
2 participants