Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: navigate to other rooms tapping at message #5488

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jan 16, 2024

Proposed changes

Regression from #5074

Issue(s)

How to test or reproduce

Testing the mentioned channels:

  • Mention a public channel that you don't be part of it into the room
  • Click on the mention
  • Click on the blue icon message to be moved to the channel

Testing the DMs:

  • Open a channel with messages from other users
  • Select a user that you never had a DM before
  • Click on the user profile
  • Click on the blue icon message to start a DM
  • Once the DM is created, click on the name of the user at the top

Screenshots

Before

Screen.Recording.2024-01-16.at.19.00.40.mov

After

Screen.Recording.2024-01-16.at.19.01.57.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-1068

@reinaldonetof reinaldonetof self-assigned this Jan 16, 2024
@reinaldonetof reinaldonetof merged commit b0d0257 into develop Jan 22, 2024
3 of 8 checks passed
@reinaldonetof reinaldonetof deleted the fix.handle-go-room branch January 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants