Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch setCategories to add support for multiple categories #5490

Merged
merged 10 commits into from
Jan 19, 2024
Merged

fix: patch setCategories to add support for multiple categories #5490

merged 10 commits into from
Jan 19, 2024

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Jan 17, 2024 •
edited by jira bot

Proposed changes

related: wix/react-native-notifications#1027

Issue(s)

How to test or reproduce

  • try replying to a message directly from push
  • try accepting a video conference call

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: NATIVE-447

@GleidsonDaniel GleidsonDaniel changed the title fix: update RNNotificationParser.m to include action in response dictionary fix: patch setCategories to accept more than one category Jan 18, 2024
@GleidsonDaniel GleidsonDaniel changed the title fix: patch setCategories to accept more than one category fix: patch setCategories to does not replace the previous category if you call the function more than once Jan 18, 2024
@GleidsonDaniel GleidsonDaniel changed the title fix: patch setCategories to does not replace the previous category if you call the function more than once fix: patch setCategories to add support for multiple categories Jan 19, 2024
@GleidsonDaniel GleidsonDaniel merged commit ec3cb3a into develop Jan 19, 2024
11 of 17 checks passed
@GleidsonDaniel GleidsonDaniel deleted the fix-reply-notification branch January 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GleidsonDaniel @diegolmello