feat: add a focus state to audio player #5491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I opted to use the event listener because it's easier to maintain and has more predictable side effects. I tried working with another variable in the AudioPlayer class, but changing that variable would require calling another function just to force the Audio component to render, and the maintenance and predictability of side effects were worse. I also considered using MMKV, as we are doing for the playback speed, but in the case of focus, it's not necessary to save locally the last focused audio value. If that value were still saved and the component was remounted, it would appear as if it were in focus again, which wouldn't be as pleasant for the user experience.
Issue(s)
How to test or reproduce
Screenshots
Before
Screen.Recording.2024-01-17.at.19.11.24.mov
After
Screen.Recording.2024-01-17.at.18.49.45.mov
Types of changes
Checklist
Further comments
TC-1034