Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: haptics feedback in app notificaiton #5507

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jan 22, 2024

Proposed changes

This PR takes into account messages received through notification subscription. This approach considers the user's Desktop and In-App notification settings and the room's settings. If the user has set not to receive notifications, the app will not vibrate even when focused on the room. If the user is in 'busy' status, they will not experience vibration. When the user is focused on a thread, it will only vibrate if they are already following the thread and receive a new message.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-578

@reinaldonetof reinaldonetof self-assigned this Jan 22, 2024
@reinaldonetof reinaldonetof merged commit e06aaf1 into develop Jan 29, 2024
3 of 8 checks passed
@reinaldonetof reinaldonetof deleted the feat.in-app-feedback branch January 29, 2024 15:54
@reinaldonetof reinaldonetof mentioned this pull request Jan 29, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants