Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove blocks when updating an old message #5522

Merged
merged 7 commits into from
Jan 31, 2024

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jan 29, 2024

Proposed changes

With the implementation of the alert when a user is mentioned and is not in the channel, a bug appeared where, after pressing the action button, these buttons are not hidden.

Issue(s)

How to test or reproduce

  • Go to a channel where you are an owner, leader or moderator
  • Mention someone outside the channel
  • It will appear some buttons as "add them", "do nothing" or "let them know"
  • After you press the buttons, this message will be updated and the buttons will hide.

Screenshots

Before

Screen.Recording.2024-01-29.at.11.19.02.mov

After

Screen.Recording.2024-01-29.at.11.17.19.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-1092

@reinaldonetof reinaldonetof self-assigned this Jan 29, 2024
@reinaldonetof reinaldonetof merged commit cc7d089 into develop Jan 31, 2024
3 of 8 checks passed
@reinaldonetof reinaldonetof deleted the improve.remove-blocks-during-update branch January 31, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants