Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add draft and quote on shareview support #5540

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Feb 5, 2024

Proposed changes

This PR includes some solutions:

  • Sending quotes and messages through ShareView.
  • Automatic saving of chat messages.
  • Editing a conversation in shareView and if the message is not sent, the edited message will be replicated in RoomView.
  • Saving quotes in draft messages.

The solution was "full" because at first I thought that saving the message and the quote in the draft would solve the share view problem.
However, I then followed another path and as they conflict, everything ended up in the same PR.

Issue(s)

How to test or reproduce

Test whether the draft is being saved automatically:

  • Type something and close the app (previously the draft was only saved if you left the room)
  • Check if the quote is being saved correctly as a draft. (Several quotes for example)

Test whether the message sent via ShareView has the correct quotes
Test previous draft flows.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: NATIVE-464

@GleidsonDaniel GleidsonDaniel marked this pull request as ready for review February 6, 2024 18:56
@diegolmello diegolmello merged commit b81e22c into develop Feb 7, 2024
2 of 4 checks passed
@diegolmello diegolmello deleted the feat-draft-quote branch February 7, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants