Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add alignSelf style for Android to prevent text from getting cut off #5571

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Feb 16, 2024

Proposed changes

using the alignSelf: 'stretch' force the text to flex lines to take up the remaining space.

Issue(s)

How to test or reproduce

Send a gimme to a room and return to the screen where it shows all rooms, the gimmer should be rendered perfectly.
Only Android 13 and up.

Screenshots

Before:
Screenshot 2024-02-16 at 16 53 23

After:
Screenshot 2024-02-16 at 16 52 57

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: NATIVE-495

@diegolmello diegolmello merged commit 079b401 into develop Feb 16, 2024
8 of 12 checks passed
@diegolmello diegolmello deleted the fix-text-cut-off-room-list-view branch February 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants