Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search emoji by substring #5585

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Lao-Ax
Copy link
Contributor

@Lao-Ax Lao-Ax commented Feb 21, 2024

Before the fix emoji could be found only by a subsctring from a string start.

For example, we have two emojis

  1. foo
  2. bar_foo

When you perform a search by keyword 'foo' only the first one will be found.

Now, both will be found.

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Before the fix emoji could be found only by a subsctring from a string start. 

For example, we have two emojis
1) foo
2) bar_foo

When you perform a search by keyword 'foo' only the first one will be found.

Now, both will be found.
@Lao-Ax Lao-Ax changed the title Update emojis.ts [IMPROVEMENTS] Search emoji by substring in any place, not just leading str Feb 21, 2024
@GleidsonDaniel GleidsonDaniel changed the title [IMPROVEMENTS] Search emoji by substring in any place, not just leading str feat: add search emoji by substring Feb 26, 2024
@GleidsonDaniel GleidsonDaniel merged commit f56f19a into RocketChat:develop Feb 26, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants