fix: floating promises and fork usage on login saga #5589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes:
As far as I could tell, there was no visible bug.
takeLatest
would cancel theloginSuccess
running anyway, while the fork was declared at the top of the saga, so there was enough time to dispatch their own saga.Issue(s)
How to test or reproduce
LOGIN_SUCCESS
saga would never finish (fixed on this PR)Screenshots
Types of changes
Checklist
Further comments
CORE-91