Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve login error message #5594

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Feb 26, 2024

Proposed changes

Currently, when there is a login error, only a generic message is displayed, this PR corrects this and adds other messages that exist on the web.

Issue(s)

resolve: #5592

How to test or reproduce

  • have a user blocked by the administrator and try to log in

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: CORE-114

@GleidsonDaniel GleidsonDaniel marked this pull request as ready for review February 26, 2024 14:01
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just case changes to match current RC copy standards

app/i18n/locales/en.json Outdated Show resolved Hide resolved
app/i18n/locales/en.json Outdated Show resolved Hide resolved
GleidsonDaniel and others added 4 commits February 28, 2024 08:09
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@GleidsonDaniel GleidsonDaniel merged commit f3ee2dc into develop Feb 28, 2024
3 of 8 checks passed
@GleidsonDaniel GleidsonDaniel deleted the improve-login-errors branch February 28, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants