Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly check the type of Accounts_AllowUserStatusMessageChange #5642

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Apr 2, 2024

Proposed changes

allowUserStatusMessageChange can be true, false or undefined
We should only disable status change if it is explicitly false.

Issue(s)

How to test or reproduce

Enable or disable the setting and see if the status change menu is visible or not.
Also check on a server that has not changed this setting (which must have the value of undefined), to see if the option exists or not.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: SUP-536

@GleidsonDaniel GleidsonDaniel merged commit 7caefa8 into develop Apr 2, 2024
7 of 12 checks passed
@GleidsonDaniel GleidsonDaniel deleted the fix-status-change branch April 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants