Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Read Receipt #758

Conversation

pranavpandey1998official
Copy link
Contributor

@RocketChat/ReactNative

Closes: #542

WhatsApp Image 2019-03-25 at 5 02 54 PM(2)
WhatsApp Image 2019-03-25 at 5 02 54 PM(1)
WhatsApp Image 2019-03-25 at 5 02 54 PM

@pranavpandey1998official
Copy link
Contributor Author

pranavpandey1998official commented Mar 25, 2019

@diegolmello I couldn't find the custom icon in the file so i just used it as used the icon used in the web app,
2) I have added the receipt icon to user.js I know its not the correct place for it but it will reduce some amount of code for the app do you want me to correct it

@diegolmello
Copy link
Member

@pranavpandey1998official Thanks for opening this PR!
It's the correct icon.
Please add the icon after the ts (on the right side).
Also, make sure to add an empty space if the message is unread (to keep dates aligned).

Also switch the action to "Message info" instead of "Read receipt".
This will open a "Message Info" screen with the message and a section "Read receipt".
In the future, we can add reactions too.

@pranavpandey1998official
Copy link
Contributor Author

@diegolmello can you explain more about 'section'? Is that going to be a button that opens a new screen? As that will be the only option feasible as we have are conditionally allowing user to see Read Receipts only when they have permissions,(also because displaying two large list is not good in single page) and also that will add another component 'message info' are we in a situation to add more code for such two operations i think we should give that option in message action itself..

@diegolmello
Copy link
Member

@pranavpandey1998official Ok, leave as it is then.

@diegolmello diegolmello changed the title added read Recipt functionality to the app [NEW] Read Receipt Mar 25, 2019
@pranavpandey1998official
Copy link
Contributor Author

WhatsApp Image 2019-03-25 at 6 47 30 PM

app/views/RoomView/Header/index.js Outdated Show resolved Hide resolved
app/views/ReadReceiptView/index.js Outdated Show resolved Hide resolved
app/views/ReadReceiptView/index.js Outdated Show resolved Hide resolved
app/views/ReadReceiptView/index.js Outdated Show resolved Hide resolved
app/views/ReadReceiptView/index.js Outdated Show resolved Hide resolved
app/containers/message/User.js Outdated Show resolved Hide resolved
app/containers/message/User.js Outdated Show resolved Hide resolved
app/containers/message/Message.js Outdated Show resolved Hide resolved
app/containers/message/Message.js Outdated Show resolved Hide resolved
app/containers/message/Message.js Outdated Show resolved Hide resolved
app/views/ReadReceiptView/index.js Outdated Show resolved Hide resolved
app/containers/MessageActions.js Outdated Show resolved Hide resolved
app/containers/message/User.js Outdated Show resolved Hide resolved
@diegolmello
Copy link
Member

@pranavpandey1998official lint isn't passing

@pranavpandey1998official
Copy link
Contributor Author

@diegolmello done

@pranavpandey1998official
Copy link
Contributor Author

resolved

@diegolmello
Copy link
Member

@pranavpandey1998official I'll delay this to 1.13, because it requires a migration and there's a beta ongoing already.

diegolmello and others added 5 commits June 3, 2019 17:16
# Conflicts:
#	app/containers/MessageActions.js
#	app/containers/message/Message.js
#	app/containers/message/User.js
#	app/containers/message/index.js
#	app/index.js
#	app/lib/realm.js
app/containers/message/Message.js Outdated Show resolved Hide resolved
app/containers/message/Message.js Outdated Show resolved Hide resolved
app/containers/message/index.js Outdated Show resolved Hide resolved
app/views/ReadReceiptView/index.js Show resolved Hide resolved
@diegolmello
Copy link
Member

image

@diegolmello diegolmello mentioned this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Read receipt
2 participants