-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Read Receipt #758
[NEW] Read Receipt #758
Conversation
@diegolmello I couldn't find the custom icon in the file so i just used it as used the icon used in the web app, |
@pranavpandey1998official Thanks for opening this PR! Also switch the action to "Message info" instead of "Read receipt". |
@diegolmello can you explain more about 'section'? Is that going to be a button that opens a new screen? As that will be the only option feasible as we have are conditionally allowing user to see Read Receipts only when they have permissions,(also because displaying two large list is not good in single page) and also that will add another component 'message info' are we in a situation to add more code for such two operations i think we should give that option in message action itself.. |
@pranavpandey1998official Ok, leave as it is then. |
@pranavpandey1998official lint isn't passing |
@diegolmello done |
resolved |
@pranavpandey1998official I'll delay this to 1.13, because it requires a migration and there's a beta ongoing already. |
# Conflicts: # app/containers/MessageActions.js # app/containers/message/Message.js # app/containers/message/User.js # app/containers/message/index.js # app/index.js # app/lib/realm.js
@RocketChat/ReactNative
Closes: #542