Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[BUG] Sidebar doesn't update all values on logout #1118

Closed
soundstorm opened this issue Jan 5, 2018 · 5 comments
Closed

[BUG] Sidebar doesn't update all values on logout #1118

soundstorm opened this issue Jan 5, 2018 · 5 comments

Comments

@soundstorm
Copy link
Contributor

When logging out from one server and switching automatically to another server following params weren't updated:

  • Server Name (retaining old servers title)
  • Profile picture (set to default svg, neither updating to the current servers image nor retaining the old servers image)
  • Online status (offline)
    So more or less the whole top elements except the username are not updated correctly in the sidebar.
@soundstorm
Copy link
Contributor Author

soundstorm commented Jan 5, 2018

Okay, with build 136 following behaviour:

  • have at least 2 servers connected
  • logout from the server at index 1 (if you log out from the topmost server it seems to work normally)
    • RC switches to server at index 0
  • open sidebar:
    • Server name = Label, username = john.appleseed, profile picture = blank

So it seems, that Subscriptions.storyboard is not updated after loading the new servers info

@soundstorm
Copy link
Contributor Author

@rafaelks this seems not to be fixed 🙈
We need to call SubscriptionsViewController.updateCurrentUserInformation() somewhere after switching server, not only on willReveal()

@soundstorm
Copy link
Contributor Author

soundstorm commented Jan 13, 2018

I'm maybe just too impatient. The values are all loaded correctly, but async. So if you open the sidebar before we got all the information of the server, the value stays at "john.appleseed" until next time opening it.

Long term: can we store the data like server name and username and load these values instead of waiting until we got them from the server? I've just seen another App showing "Label" for a short time somewhere, but may look unprofessional to some people 😇
settings.serverName is already available, so we need to store user.displayName() and maybe the reference to the profile picture.

Goal: rock solid app 👊

@rafaelks
Copy link
Contributor

@soundstorm Yeah, I also reproduced this issue, this really isn't cool. Let's reopen this issue, thank you!

@rafaelks
Copy link
Contributor

This is going to be addressed soon by
#731, so let's close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants