This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Improving project build time #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sameesunkaria
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1440 +/- ##
===========================================
+ Coverage 25.56% 25.57% +0.01%
===========================================
Files 236 236
Lines 12089 12083 -6
===========================================
Hits 3090 3090
+ Misses 8999 8993 -6
Continue to review full report at Codecov.
|
filipealva
approved these changes
Mar 27, 2018
There was a problem hiding this comment.
@Sameesunkaria It's looking awesome! It will improve our productivity a lot. The incremental build is unbelievably fast.
Thank you!
Cycle 03: 03/05 ~ 03/27
automation
moved this from In progress (by contributor)
to Done
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Emojis have been moved out of the swift struct to a JSON file. And the
allvariable inEmojionehas been changed to a constant with a closure for initialization. The result forallis now calculated differently.The swift compiler code generation for optimization has been changed to, no optimization on debug builds and safety checks have been disabled for debug builds.
The
Emojioneshould compile a lot faster. Also, after some testing, I'm fairly positive that these changes no not measurably impact the performance of the app on runtime.I was able to get the build time to about 30 seconds (MacBook Air) on incremental builds.
For Reviewers: Test the incremental build time. Should be substantially better.
P.S. Huge props to Robert Gummesson for their BuildTimeAnalyzer https://github.com/RobertGummesson/BuildTimeAnalyzer-for-Xcode
Closes #1435