This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Improve image compression #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sameesunkaria There's a test in |
|
@Sameesunkaria Looking super good!!! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
The image compression is not performed based on pre-calculated heuristics. An estimated size of the image after compression is determined based on the heuristics. This information is then used to calculate the new dimensions of the image so that it fits under the size constraints defined by
FileUpload_MaxFileSize.The heuristics were based on the stats below:
Stats
Percentage size vs compression quality
Percentage size vs percentage dimension
Closes #1786