[FIX] Add chat message search back to the app #2097
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2097 +/- ##
===========================================
- Coverage 35.72% 35.47% -0.26%
===========================================
Files 382 382
Lines 17918 17916 -2
===========================================
- Hits 6402 6355 -47
- Misses 11516 11561 +45
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| @IBAction func buttonMoreDidPressed(_ sender: Any) { | ||
| delegate?.titleViewButtonMoreDidPressed() | ||
| @IBAction func buttonSearchDidPressed(_ sender: Any) { |
There was a problem hiding this comment.
Why do ChatTitleView manages the search button? For me it's supposed to be a UIBarButtonItem. The title view should limit itself to manage everything that goes between the left and the right bar button items.
There was a problem hiding this comment.
That's how the ellipsis button was implemented 😅. I can add it as a BarButtonItem if you want.
There was a problem hiding this comment.
Got it. It would be nice if you could do it :D
There was a problem hiding this comment.
@filipealva done
@RocketChat/ios
Tested on
Screenshots
Closes #2050