Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[CRASH] Fixed crash on reusing cells for Auth controller #2176

Merged
merged 1 commit into from Sep 6, 2018

Conversation

rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Sep 6, 2018

@RocketChat/ios

Closes #2175

@rafaelks rafaelks added this to the 3.2.0 milestone Sep 6, 2018
@rafaelks rafaelks added this to In Progress in Cycle 09: 09/05 ~ 09/27 via automation Sep 6, 2018
@rafaelks rafaelks closed this Sep 6, 2018
Cycle 09: 09/05 ~ 09/27 automation moved this from In Progress to Done Sep 6, 2018
@rafaelks rafaelks reopened this Sep 6, 2018
Cycle 09: 09/05 ~ 09/27 automation moved this from Done to In Progress Sep 6, 2018
@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@740fe0e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2176   +/-   ##
==========================================
  Coverage           ?   35.38%           
==========================================
  Files              ?      391           
  Lines              ?    18512           
  Branches           ?        0           
==========================================
  Hits               ?     6551           
  Misses             ?    11961           
  Partials           ?        0
Impacted Files Coverage Δ
...hat/Controllers/Auth/AuthTableViewController.swift 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740fe0e...20812a9. Read the comment docs.

Cycle 09: 09/05 ~ 09/27 automation moved this from In Progress to In Review / QA Sep 6, 2018
Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@filipealva filipealva merged commit ca67cb7 into develop Sep 6, 2018
Cycle 09: 09/05 ~ 09/27 automation moved this from In Review / QA to Done Sep 6, 2018
@rafaelks rafaelks deleted the crash/auth_tableview_reuse_cells.2175 branch September 6, 2018 13:59
@rafaelks rafaelks modified the milestones: 3.2.0, 3.1.1 Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants