Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] File attachment #2225

Merged

Conversation

filipealva
Copy link
Collaborator

@RocketChat/ios

@rafaelks rafaelks added this to the 3.2.0 milestone Sep 29, 2018
@rafaelks rafaelks added this to In Progress in Cycle 09: 09/05 ~ 09/27 via automation Sep 29, 2018
@codecov
Copy link

codecov bot commented Sep 29, 2018

Codecov Report

Merging #2225 into feature/integrate-rc-view-controller will increase coverage by 0.24%.
The diff coverage is 4.44%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/integrate-rc-view-controller    #2225      +/-   ##
========================================================================
+ Coverage                                  27.9%   28.14%   +0.24%     
========================================================================
  Files                                       400      402       +2     
  Lines                                     14989    14994       +5     
========================================================================
+ Hits                                       4182     4220      +38     
+ Misses                                    10807    10774      -33
Impacted Files Coverage Δ
.../Chat/New Chat/ChatItems/FileMessageChatItem.swift 0% <0%> (ø)
...Controllers/Chat/ChatSections/MessageSection.swift 1.94% <0%> (-0.22%) ⬇️
...at/Views/Chat/New Chat/Cells/FileMessageCell.swift 0% <0%> (ø)
...Chat/Controllers/Chat/MessagesViewController.swift 46.34% <50%> (-2.38%) ⬇️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 80% <0%> (-20%) ⬇️
...ontrollers/Base/Main/MainSplitViewController.swift 45% <0%> (-7.5%) ⬇️
...ons/SubscriptionsList/SubscriptionsViewModel.swift 5.3% <0%> (-1.77%) ⬇️
...ket.Chat/Controllers/Chat/ChatViewController.swift 0% <0%> (ø) ⬆️
.../Chat/MessagesViewControllerComposerDelegate.swift
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4e5bc...b0fed6e. Read the comment docs.

Cycle 09: 09/05 ~ 09/27 automation moved this from In Progress to In Review / QA Sep 29, 2018
@rafaelks rafaelks merged commit 850bbac into feature/integrate-rc-view-controller Sep 29, 2018
Cycle 09: 09/05 ~ 09/27 automation moved this from In Review / QA to Done Sep 29, 2018
@rafaelks rafaelks deleted the feature/file-attachment branch September 29, 2018 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants