Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Image component #2228

Conversation

rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Oct 1, 2018

@RocketChat/ios

@rafaelks rafaelks added this to the 3.2.0 milestone Oct 1, 2018
@rafaelks rafaelks added this to In Progress in Cycle 09: 09/05 ~ 09/27 via automation Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #2228 into feature/integrate-rc-view-controller will decrease coverage by 0.09%.
The diff coverage is 1.61%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           feature/integrate-rc-view-controller    #2228     +/-   ##
=======================================================================
- Coverage                                 27.83%   27.73%   -0.1%     
=======================================================================
  Files                                       402      404      +2     
  Lines                                     15030    15087     +57     
=======================================================================
+ Hits                                       4184     4185      +1     
- Misses                                    10846    10902     +56
Impacted Files Coverage Δ
...t.Chat/Views/Cells/Chat/ChatMessageImageView.swift 73.8% <ø> (ø) ⬆️
...Controllers/Chat/ChatSections/MessageSection.swift 1.8% <0%> (-0.15%) ⬇️
...t/Views/Chat/New Chat/Cells/ImageMessageCell.swift 0% <0%> (ø)
...llers/Chat/ChatControllerMessageCellProtocol.swift 0% <0%> (ø) ⬆️
...Chat/New Chat/ChatItems/ImageMessageChatItem.swift 0% <0%> (ø)
...Chat/Controllers/Chat/MessagesViewController.swift 50% <100%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850bbac...1c093a0. Read the comment docs.

@rafaelks rafaelks changed the title [WIP][NEW] Image component [NEW] Image component Oct 1, 2018

func isContentEqual(to source: ImageMessageChatItem) -> Bool {
return
identifier == source.identifier &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed and we shouldn't check for identity here, just for content equality.

Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine. Don't mind the little comment about checking the identifier on isContentEqual we can change it later together with any another occurence that might exist.

Cycle 09: 09/05 ~ 09/27 automation moved this from In Progress to In Review / QA Oct 2, 2018
@filipealva filipealva merged commit 6effff4 into feature/integrate-rc-view-controller Oct 2, 2018
Cycle 09: 09/05 ~ 09/27 automation moved this from In Review / QA to Done Oct 2, 2018
@filipealva filipealva deleted the feature/image_attachment_component branch October 2, 2018 03:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants