[NEW] Image component #2228
[NEW] Image component #2228
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2228 +/- ##
=======================================================================
- Coverage 27.83% 27.73% -0.1%
=======================================================================
Files 402 404 +2
Lines 15030 15087 +57
=======================================================================
+ Hits 4184 4185 +1
- Misses 10846 10902 +56
Continue to review full report at Codecov.
|
|
||
func isContentEqual(to source: ImageMessageChatItem) -> Bool { | ||
return | ||
identifier == source.identifier && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed and we shouldn't check for identity here, just for content equality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine. Don't mind the little comment about checking the identifier on isContentEqual
we can change it later together with any another occurence that might exist.
@RocketChat/ios