Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Invalidate collection view layout on screen rotation #2245

Conversation

filipealva
Copy link
Collaborator

@RocketChat/ios

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2245 into feature/integrate-rc-view-controller will decrease coverage by 0.4%.
The diff coverage is 0%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/integrate-rc-view-controller    #2245      +/-   ##
========================================================================
- Coverage                                  27.1%   26.69%   -0.41%     
========================================================================
  Files                                       418      418              
  Lines                                     15726    15739      +13     
========================================================================
- Hits                                       4262     4201      -61     
- Misses                                    11464    11538      +74
Impacted Files Coverage Δ
...Chat/Controllers/Chat/MessagesViewController.swift 40.98% <0%> (-11.1%) ⬇️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
...cket.Chat/Managers/Model/AuthSettingsManager.swift 29.16% <0%> (-33.34%) ⬇️
...Chat/Models/Subscription/SubscriptionQueries.swift 75% <0%> (-25%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-10.35%) ⬇️
...at/API/Requests/General/LoginServicesRequest.swift 90% <0%> (-10%) ⬇️
...Controllers/Auth/ConnectServerViewController.swift 52.5% <0%> (-5.5%) ⬇️
Rocket.Chat/Managers/AppManager.swift 41.61% <0%> (-4.7%) ⬇️
...ontrollers/Base/Main/MainSplitViewController.swift 52.5% <0%> (+7.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e152a3b...31ef3d9. Read the comment docs.

self?.collectionView.reloadData()
}, completion: { [weak self] _ in
if let indexPath = topIndexPath {
self?.collectionView.scrollToItem(at: indexPath, at: .bottom, animated: false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working 100% yet, but let's merge it and improve later.

@rafaelks rafaelks merged commit 21f1797 into feature/integrate-rc-view-controller Oct 10, 2018
@rafaelks rafaelks deleted the improvement/invalidate-layout-on-rotation branch October 10, 2018 14:50
@rafaelks rafaelks added this to the 3.2.0 milestone Oct 10, 2018
@rafaelks rafaelks added this to In Progress in Cycle 10: 10/05 ~ 11/05 via automation Oct 10, 2018
@rafaelks rafaelks moved this from In Progress to Done in Cycle 10: 10/05 ~ 11/05 Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants