[CHORE] Resolve couple code warnings in the project #2246
[CHORE] Resolve couple code warnings in the project #2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 💯 just waiting the CI pass to merge
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2246 +/- ##
=======================================================================
- Coverage 26.86% 26.77% -0.1%
=======================================================================
Files 418 418
Lines 15739 15700 -39
=======================================================================
- Hits 4229 4204 -25
+ Misses 11510 11496 -14
Continue to review full report at Codecov.
|
@@ -48,7 +48,7 @@ extension MessageManager { | |||
let subscriptionIdentifier = subscription.identifier | |||
|
|||
currentRealm?.execute({ (realm) in | |||
guard let detachedSubscription = realm.object(ofType: Subscription.self, forPrimaryKey: subscriptionIdentifier ?? "") else { return } | |||
guard let detachedSubscription = realm.object(ofType: Subscription.self, forPrimaryKey: subscriptionIdentifier) else { return } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line Length Violation: Line should be 120 characters or less: currently 143 characters (line_length)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@RocketChat/ios