This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Video message header #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… called in the subclasses
…he message's header and adapt MessageSection and MessagesViewController to support it
houndci-bot
reviewed
Oct 15, 2018
| let videoThumbPath: URL? | ||
| let hasText: Bool | ||
|
|
||
| init(identifier: String, descriptionText: String?, videoURL: URL?, videoThumbPath: URL?, hasText: Bool, user: UnmanagedUser?, message: UnmanagedMessage?) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 159 characters (line_length)
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2251 +/- ##
========================================================================
- Coverage 26.95% 26.53% -0.43%
========================================================================
Files 419 423 +4
Lines 15746 15877 +131
========================================================================
- Hits 4245 4213 -32
- Misses 11501 11664 +163
Continue to review full report at Codecov.
|
rafaelks
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Needs #2250 to be merged first