This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Add support to Headers & Loaders to the View Model & much more tests #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 25, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths Rocket.Chat/Views/Chat/New, Chat/Cells/UnreadMarkerCell.swift No lintable files found at paths: 'Rocket.Chat/Views/Chat/New, Chat/Cells/UnreadMarkerCell.swift'
| var containsDateSeparator: Bool { return daySeparator != nil } | ||
|
|
||
| init(message: UnmanagedMessage, daySeparator: Date? = nil, sequential: Bool = false, unreadIndicator: Bool = false) { | ||
| init(message: UnmanagedMessage, daySeparator: Date? = nil, sequential: Bool = false, unreadIndicator: Bool = false, loader: Bool = false, header: Bool = false) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 165 characters (line_length)
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2263 +/- ##
========================================================================
+ Coverage 25.73% 25.82% +0.08%
========================================================================
Files 434 436 +2
Lines 16341 16367 +26
========================================================================
+ Hits 4206 4226 +20
- Misses 12135 12141 +6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
First needs to merge #2262