Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[CHORE] Refactor chat theme adoption #2267

Conversation

filipealva
Copy link
Collaborator

@RocketChat/ios

A big thanks to @Sameesunkaria for letting me know that these improvements were needed 馃憤

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #2267 into feature/integrate-rc-view-controller will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/integrate-rc-view-controller    #2267      +/-   ##
========================================================================
+ Coverage                                 25.59%   25.61%   +0.02%     
========================================================================
  Files                                       437      437              
  Lines                                     16513    16507       -6     
========================================================================
+ Hits                                       4227     4229       +2     
+ Misses                                    12286    12278       -8
Impacted Files Coverage 螖
Rocket.Chat/Theme/ThemeableViews.swift 52.53% <酶> (+1.61%) 猬嗭笍
...Chat/Controllers/Chat/MessagesViewController.swift 44.59% <100%> (+3.26%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1ef706e...5f89dcf. Read the comment docs.

@rafaelks rafaelks added this to the 3.2.0 milestone Oct 29, 2018
@rafaelks rafaelks added this to In Progress in Cycle 10: 10/05 ~ 11/05 via automation Oct 29, 2018
Cycle 10: 10/05 ~ 11/05 automation moved this from In Progress to In Review / QA Oct 29, 2018
Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃

@rafaelks rafaelks merged commit fab3bf4 into feature/integrate-rc-view-controller Oct 29, 2018
Cycle 10: 10/05 ~ 11/05 automation moved this from In Review / QA to Done Oct 29, 2018
@rafaelks rafaelks deleted the chore/refactor-chats-theme-adoption branch October 29, 2018 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants